init markdown-edit-block#66
Merged
Wattenberger merged 9 commits intomainfrom Aug 9, 2022
Merged
Conversation
Wattenberger
commented
Aug 2, 2022
| ".cm-cursor, .cm-dropCursor": { borderLeftColor: colors.cursor }, | ||
| "&.cm-focused .cm-selectionBackground, .cm-selectionBackground, .cm-content ::selection": | ||
| { backgroundColor: colors.bg }, | ||
| { backgroundColor: colors.selectionBg }, |
Contributor
Author
There was a problem hiding this comment.
something I noticed poking around here - lil fix
Wattenberger
force-pushed
the
aw/markdown-edit-block
branch
from
7a1f065 to
07e590f
Compare
Contributor
mattrothenberg
left a comment
mattrothenberg
left a comment
There was a problem hiding this comment.
Looking very cool. I wasn't able to dive too deeply into the CodeMirror bits, but it's working on my end
mattrothenberg
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also includes a new Sandbox Block, to replace the CodeSandbox components in the old Markdown preview Block.
Todo later: